At the moment, depending on the network a lot of expired cookies can be returned. It would be nice if the tool could filter out those (at least by default). In the same idea, a lot of cookies can be empty so 99.9% of the time useless, this could also be filtered out.

Hi, When running the DonPAPI.py script I get the following python error:

File "./DonPAPI.py", line 157
    logging.info(f"Loaded {len(credz)} user credentials")
                                                       ^
SyntaxError: invalid syntax

Steps to reproduce:

git clone https://github.com/login-securite/DonPAPI.git
pip3 install -r requirements.txt
./DonPAPI.py

This looks like a great tool, looking forward to using it!

The VNC plugin in software/sysadmin/vnc.py does not handle properly the read of a registry key.

There is two issues:

• After getting the key from registry, the variable is bytes, but on line 107, you triy to rstrip() some string, causing an error.
• On the reverse_vncpassword method, you try to unhex/hex the same variable, but as it's bytes and not a string hex representation, it fails.

On the bottom of the readme you write that a lot of code comes from cme. I would love to see the project as a cme module. Is that currently on focus? Maybe you can write your thoughts about this and maybe some hints how to start with this project on my own.

Cheers.

Bonjour à tous, ça fait un p'tit moment que j'utilise DonPAPI et depuis une fresh install de Kali j'ai une erreur que je n'arrive pas debbugger si quelqu'un a une idée je suis preneur:

python3 DonPAPI.py

Traceback (most recent call last): File "DonPAPI.py", line 27, in from myseatbelt import MySeatBelt File "myseatbelt.py", line 12, in from lib.secretsdump import LSASecrets as MyLSASecrets ModuleNotFoundError: No module named 'lib.secretsdump'

Alors que la lib est bien dispo dasn e dossier d'installation dans lib/secretsdump Pour être sûr de moi j'avais ajouté le chemin d'exécution dans la variable $PATH, mais rien n'y fait.

Je n'ai aucune idée de comment debbugger ceci.

D'avance merci de l'attention porté à mon problème !

Currently this tool allows reading files via SMB only.

I would like to run it locally, using Kali Live, with Windows drive(s) mounted in eg. /mnt/c, /mnt/d etc.

DonPAPI does a fantastic job of retrieving saved login credentials, however the option to retrieve cookies would be beneficial to be able to steal existing sessions and bypass 2FA protection. Currently it seems an attempt was made at adding this feature but it may have been abandoned (https://github.com/login-securite/DonPAPI/blob/main/myseatbelt.py#L460). I might try and have a go at this in a few weeks but not sure if I'll be able to pull it off.

When running DonPAPI with "--GetHashes" I get the following error.

Traceback (most recent call last):
  File "/<mytoolspath>/DonPAPI/DonPAPI.py", line 273, in <module>
    main()
  File "/<mytoolspath>/DonPAPI/DonPAPI.py", line 185, in main
    my_report.export_hashes()
AttributeError: 'reporting' object has no attribute 'export_hashes'

DonPAPI is running on KALI 2021.4 with Impacket v0.9.24.dev1+20210720.100427.cd4fe47c. The target is Windows 10 1803

The "--no_recent" and "--no_sysamins" options have the wrong description:

attacks:
  --no_browser          do not hunt for browser passwords
  --no_dpapi            do not hunt for DPAPI secrets
  --no_vnc              do not hunt for VNC passwords
  --no_remoteops        do not hunt for SAM and LSA with remoteops
  --GetHashes           Get all users Masterkey's hash & DCC2 hash
  --no_recent           Get recent files
  --no_sysadmins        Get sysadmins stuff (mRemoteNG, vnc, keepass, lastpass ...)

The Word "Get" should be replaced by "do not hunt for" for --no_recent and --no_sysamins

• [x] pyproject.toml: proper pyproject.toml
• [x] readme: markdown compliant with https://commonmark.org/
• [x] readme: add alternative poetry install steps

Before pyproject.toml update

$ poetry build
Creating virtualenv donpapi-dfVQVXBX-py3.10 in /home/noraj/.cache/pypoetry/virtualenvs
Building donpapi (1.0.0)

$ python -m build --wheel
* Creating virtualenv isolated environment...
* Installing packages in isolated environment... (poetry-core>=1.0.0)
* Getting dependencies for wheel...
* Building wheel...
Traceback (most recent call last):
  File "/usr/lib/python3.10/site-packages/pep517/in_process/_in_process.py", line 351, in <module>
    main()
  File "/usr/lib/python3.10/site-packages/pep517/in_process/_in_process.py", line 333, in main
    json_out['return_val'] = hook(**hook_input['kwargs'])
  File "/usr/lib/python3.10/site-packages/pep517/in_process/_in_process.py", line 249, in build_wheel
    return _build_backend().build_wheel(wheel_directory, config_settings,
  File "/tmp/build-env-lekq9y_k/lib/python3.10/site-packages/poetry/core/masonry/api.py", line 67, in build_wheel
    return WheelBuilder.make_in(poetry, Path(wheel_directory))
  File "/tmp/build-env-lekq9y_k/lib/python3.10/site-packages/poetry/core/masonry/builders/wheel.py", line 74, in make_in
    wb = WheelBuilder(
  File "/tmp/build-env-lekq9y_k/lib/python3.10/site-packages/poetry/core/masonry/builders/wheel.py", line 57, in __init__
    super().__init__(poetry, executable=executable)
  File "/tmp/build-env-lekq9y_k/lib/python3.10/site-packages/poetry/core/masonry/builders/builder.py", line 83, in __init__
    self._module = Module(
  File "/tmp/build-env-lekq9y_k/lib/python3.10/site-packages/poetry/core/masonry/utils/module.py", line 69, in __init__
    raise ModuleOrPackageNotFound(
poetry.core.masonry.utils.module.ModuleOrPackageNotFound: No file/folder found for package donpapi

ERROR Backend subprocess exited when trying to invoke build_wheel

cf. https://github.com/python-poetry/poetry/issues/1110

After pyproject.toml update

$ poetry build           
Building donpapi (1.0.0)
  - Building sdist
  - Built donpapi-1.0.0.tar.gz
  - Building wheel
  - Built donpapi-1.0.0-py3-none-any.whl

$  python -m build --wheel
* Creating virtualenv isolated environment...
* Installing packages in isolated environment... (poetry-core>=1.0.0)
* Getting dependencies for wheel...
* Building wheel...
Successfully built donpapi-1.0.0-py3-none-any.whl

adding a section for cookies in the report cookies expire date are printed in readable format section are toggled by default show number of credz in each sections top bar

Hello,

Nice project !

I wanted to give you some idea to deal with Lazagne modules. I think you could not managed with the lazagne project but you should use lazagne forensic which has been designed to have a similar idea. The project is not up to date but could be done easily copying the code from lazagne modules and modifying from where the data are retrieved.

What I would suggest you is to integrate lazagneforensic as an external project (like we do in pupy: https://github.com/n1nj4sec/pupy/tree/unstable/pupy/external), and you load the project as module into the code. We update all lazagneForensic modules and fix some compatible issue with your project (if there are).

Like that if a fix is done on your project or mine, it could be easily fixed.

If you don't want and want to do your own things, I have no problems with it.

Have a nice day.

Hi,

This project looks amazing and solves a large amount of possible problems, However looking at the codebase I wasn't able to find a LICENSE file, The only thing I could find is a message in the master file indicating the license is a modified version of Apache license with more details in the LICENSE file that I wasn't able to find.

This software is provided under under a slightly modified version

of the Apache Software License. See the accompanying LICENSE file

for more information.

If a license file could be added it will be great help !