• The image should be pushed to this repo: https://hub.docker.com/r/bledy/timezone-converter (I guess we would need a secret, for example DOCKER_HUB_TOKEN).
• The image should use the same tag as the release that triggered the workflow (without the v prefix)

Trying to fix #19

Usage:

# List all letter groups
$ timezone-converter --list
# List timezones beginning with 'm'
$ timezone-converter --list m
# List timezones beginning with 'b', 'd', or 't'
$ timezone-converter --list bdt

I tried to fix #3

I added the -s (--single) option to the command line input and enabled the programme to output a single hour.

Usage: Output a single hour for current time.

$ timezone-converter hong_kong tokyo -s now
$ timezone-converter hong_kong tokyo --single now

Output a given hour specified by the user (e.g. 16).

$ timezone-converter hong_kong tokyo -s 16
$ timezone-converter hong_kong tokyo --single 16

This would add a --search option to the cli, which can be used to search timezones by name.

Examples:

$ timezone-converter --search "new york"
Found 1 timezone: "new_york"

$ timezone-converter --search mad
Found 2 timezones: "madeira", "madrid"

When the user inputs multiple timezones, we could sort the output so after the local timezone there's always the one that has the least difference.

• We should try to preserve the user order, so if there's no difference we use the input order.

• We may also add an argument to preserve the user order even if the sorted output would be different. Maybe we can use--preserve-order or --no-sort? Or maybe even have this feature as an opt-in via --order

For example, in the following screenshot, new_york has less difference than tijuana, so the sorted output would be:

1. local
2. new_york
3. tijuana

When the user inputs a timezone that is not in the list, we should fuzzy search for similar ones to offer a suggestion.

We can also have a fuzzy search capability in case the --list option is not useful enough

Added new feature for showing time-zone differences with the local and the timezone entered by the user in hours. It also shows whether the user's time is ahead or behind the timezone entered.

Fixed #12

Using the text formatting tool in rich, I added some code to highlight the row with current hour in red. Please let me know if other colours/formats are preferred and I may change the highlight. :)

The action we are currently using to upload assets to a release is not being actively maintained, so we need to replace it.

We recently replaced https://github.com/actions/create-release with https://github.com/softprops/action-gh-release, which already has the option to upload assets (it would also allow us to do it in a single step).

updates:

• github.com/asottile/reorder_python_imports: v3.8.3 → v3.9.0
• github.com/asottile/setup-cfg-fmt: v2.0.0 → v2.2.0
• github.com/psf/black: 22.8.0 → 22.10.0
• github.com/pre-commit/mirrors-mypy: v0.981 → v0.982

updates:

• github.com/asottile/reorder_python_imports: v3.3.0 → v3.8.3
• github.com/asottile/add-trailing-comma: v2.2.3 → v2.3.0
• github.com/Lucas-C/pre-commit-hooks: v1.2.0 → v1.3.1
• github.com/asottile/setup-cfg-fmt: v1.20.1 → v2.0.0
• github.com/psf/black: 22.6.0 → 22.8.0
• github.com/pycqa/flake8: 4.0.1 → 5.0.4
• github.com/asottile/yesqa: v1.3.0 → v1.4.0
• github.com/pre-commit/mirrors-mypy: v0.961 → v0.981

updates:

• github.com/pre-commit/pre-commit-hooks: v4.3.0 → v4.4.0
• github.com/pycqa/flake8: 5.0.4 → 6.0.0
• github.com/pre-commit/mirrors-mypy: v0.982 → v0.991

Issue:

The timezone output of the gmt+x and gmt-x seems to be swapped. For the reference, Hong Kong is in GMT+8.

Step to reproduce:

$ timezone-converter --version
timezone-converter 0.12.1

$ timezone-converter hong_kong gmt-5 gmt+5

┏━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━┓
┃      LOCAL       ┃  ASIA/HONG_KONG  ┃    ETC/GMT-5     ┃    ETC/GMT+5     ┃
┡━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━┩
│ 2022-11-24 00:00 │ 2022-11-24 00:00 │ 2022-11-23 21:00 │ 2022-11-23 11:00 │
│ 2022-11-24 01:00 │ 2022-11-24 01:00 │ 2022-11-23 22:00 │ 2022-11-23 12:00 │
│ 2022-11-24 02:00 │ 2022-11-24 02:00 │ 2022-11-23 23:00 │ 2022-11-23 13:00 │
│ 2022-11-24 03:00 │ 2022-11-24 03:00 │ 2022-11-24 00:00 │ 2022-11-23 14:00 │
│ 2022-11-24 04:00 │ 2022-11-24 04:00 │ 2022-11-24 01:00 │ 2022-11-23 15:00 │
...

I quickly implemented a solution to #18 issue yet I could not follow up your whole conversation so I do not know if this problem has been already resolved or not. Nevertheless, this is my idea.

Changes in main.py I added new flag for showing differences --difference as an argument to argparser. I had to add new argument to ComparisonView object.

Changes in comparison_view.py I had to introduce new parameter to ComparisonView in order the difference would work (it follows the design for --zone). I also had to adjust _get_header method for the new functionality. And finally I add method _difference_string which computes the difference between time zones and returns string containing that difference.

I think we should change the argument to something like --hour. Initially we used -s/--single to avoid collision with -h (help) argument. Hour seems more appropiate, but suggestions are welcome.

The initial work was discussed in #3, and done in #16.

It's such a pleasure to use and work on this amazing project and thanks @ibLeDy for your work. 🎉

Just a suggested change from my experience of working on this project.

I sometimes find the programme name (timezone-converter) too long to type in the command line when testing my PR or running the programme. It would be nice to use a shorter name like tz-conv or tz-convert (can be anything). The current repo name can still remain unchanged.

For example, timezone-converter --list can possibly be tz-conv --list

We can show what the hour difference is, maybe where we show the --zone.

• It can be just a number, but I think we should use gmt+
• We can use an argument like --difference