Even when I copy paste the example code regarding getting live flights prices from the documentation I am getting this error. I'm kinda new to python so I'm not certain where the error lies.

My test code: `from skyscanner import Flights

flights_service = Flights('un173418880453608449381682534785') result = flights_service.get_result( country='US', currency='USD', locale='en-US', originplace='DEN-sky', destinationplace='PHX-sky', outbounddate='2016-09-02', inbounddate='2016-09-06', adults=1).parsed `

Error codes: File "\skyscanner\test.py", line 12, in adults=1).parsed File "\skyscanner.py", line 130, in get_result return self.poll_session(self.create_session(*_params), errors=errors, *_additional_params) File "\skyscanner.py", line 224, in poll_session errors=errors, **params) File "\skyscanner.py", line 179, in make_request return self._with_error_handling(r, e, error_mode, self.response_format) File "\skyscanner.py", line 288, in _with_error_handling raise error EmptyResponse(Response has no content.)

This PR updates the SDK such that:

1. introduce flake8 as part of Travis CI build to ensure that we follow PEP8 guidelines as close as possible.
2. reordering of imports to follow import guidelines from PEP8 (ref: https://www.python.org/dev/peps/pep-0008/#imports).

I have explicitly set flake8 config to ignore max line length (defaults at 79 chars) though. perhaps we want to enforce a specific max line length?

Hi, is it just my setup or does the sdk currently not work. I just tried run a basic example from the usage section of the docs and got an

skyscanner.skyscanner.EmptyResponse: Response has no content.

I also tried to run the test, which also showed this result

2016-03-05 08:08:27,617 - skyscanner.py:239 - WARNING - Response has no content.

We have received the notification from Skyscanner that by April 30, 2020, all the http requests to the API should be replaced by https. The respective change needs to be done in this package. Otherwise it will stop working. As I see, it is a single line change. I am happy to contribute if needed.

https://skyscanner.github.io/slate/#https-migration-guide

" from skyscanner import Flights

flights_service = Flights('un916353397293877852942657332487') result = flights_service.get_result( stops = 0, country='US', currency='USD', locale='en-US', originplace='DTW-sky', destinationplace='PEK-sky', outbounddate='2016-06-29', inbounddate='2016-07-30').parsed

print result "

the parameter of "stops" doesn't work.

is my way not right? how could I solve it? I just simply want to add a stop parameter to filter the result.

Hi, I was using version 1.1.0 of the sdk and when I followed this example it would work just fine:

flights_cache_service = FlightsCache('<Your API Key>')
result = flights_cache_service.get_cheapest_price_by_date(
    country='UK',
    currency='GBP',
    locale='en-GB',
    originplace='SIN-sky',
    destinationplace='KUL-sky',
    outbounddate='2015-05',
    inbounddate='2015-06')

Now, on the version 1.1.1, I've seen that we need to pass the "market" parameter as well. So far so good. But when I make the request just like the example above (adding the market), the response only shows the Http code. I get "Response [200]", but not the data itself.

Is this an issue or am I doing something wrong? Thanks!

Hi, two commits in this pull request. The first one is just formatting, no actual code changes there. The seconds one contains the actual change.

We are about to use SkyScanner APIs in my company and since Python is one of our main tools, we are looking forward to use and contribute to this SDK.

I also have a question related to those tests: it seems that throttling is making them fail from time to time, do you think if it is possible to do something about that? Maybe use some specific 'unit test' key?

Cheers, Denis

Hi, I compare result request via API and skyscanner website to get the same hotel from the same date and city, the result is diff between skycanner website and my api result request. In my API result the guests ratio is always 0 without any description like on skyscanner website, also I never get reviews summary eventho the reviews not 0 (for example: 1296)

Any idea how to get those guests ratio and description also the reviews summary?

Thanks

After having trouble getting the example to work (with a valid key) returning simply with "Response has no content", I tried the test suite getting to work (from master branch), but unfortunately it seems to have similar problems with parsing the content (using Python 2.7.11/homebrew/Mac OS X 10.10.5):

running test
running egg_info
writing requirements to skyscanner.egg-info/requires.txt
writing skyscanner.egg-info/PKG-INFO
writing top-level names to skyscanner.egg-info/top_level.txt
writing dependency_links to skyscanner.egg-info/dependency_links.txt
reading manifest file 'skyscanner.egg-info/SOURCES.txt'
reading manifest template 'MANIFEST.in'
warning: no files found matching 'LICENSE'
warning: no previously-included files matching '__pycache__' found under directory '*'
warning: no previously-included files matching '*.py[co]' found under directory '*'
writing manifest file 'skyscanner.egg-info/SOURCES.txt'
running build_ext
test_create_session (tests.test_skyscanner.TestCarHire) ... ok
test_get_result_json (tests.test_skyscanner.TestCarHire) ... ok
test_location_autosuggest_json (tests.test_skyscanner.TestCarHire) ... ok
test_location_autosuggest_xml (tests.test_skyscanner.TestCarHire) ... ok
test_create_session (tests.test_skyscanner.TestFlights) ... ok
test_get_cheapest_price_by_date_json (tests.test_skyscanner.TestFlights) ... ok
test_get_cheapest_price_by_date_xml (tests.test_skyscanner.TestFlights) ... ok
test_get_cheapest_price_by_route_json (tests.test_skyscanner.TestFlights) ... ok
test_get_cheapest_price_by_route_xml (tests.test_skyscanner.TestFlights) ... ok
test_get_cheapest_quotes_json (tests.test_skyscanner.TestFlights) ... ok
test_get_cheapest_quotes_xml (tests.test_skyscanner.TestFlights) ... ok
test_get_grid_prices_by_date_json (tests.test_skyscanner.TestFlights) ... ok
test_get_grid_prices_by_date_xml (tests.test_skyscanner.TestFlights) ... ok
test_get_result_json (tests.test_skyscanner.TestFlights) ... 2016-06-28 23:06:44,396 - skyscanner.py:262 - WARNING - Response has no content.
2016-06-28 23:06:49,489 - skyscanner.py:262 - WARNING - Response has no content.
2016-06-28 23:06:53,145 - skyscanner.py:262 - WARNING - Response has no content.
2016-06-28 23:06:56,948 - skyscanner.py:262 - WARNING - Response has no content.
2016-06-28 23:06:58,715 - skyscanner.py:262 - WARNING - Response has no content.
2016-06-28 23:07:00,077 - skyscanner.py:262 - WARNING - Response has no content.
2016-06-28 23:07:01,467 - skyscanner.py:262 - WARNING - Response has no content.
2016-06-28 23:07:02,934 - skyscanner.py:262 - WARNING - Response has no content.
2016-06-28 23:07:04,302 - skyscanner.py:262 - WARNING - Response has no content.
2016-06-28 23:07:05,598 - skyscanner.py:262 - WARNING - Response has no content.
2016-06-28 23:07:06,897 - skyscanner.py:262 - WARNING - Response has no content.
FAIL
test_get_result_xml (tests.test_skyscanner.TestFlights) ... ok
test_create_session (tests.test_skyscanner.TestHotels) ... ok
test_get_result_json (tests.test_skyscanner.TestHotels) ... ok
test_get_result_xml (tests.test_skyscanner.TestHotels) ... ok
test_location_autosuggest_json (tests.test_skyscanner.TestHotels) ... ok
test_location_autosuggest_xml (tests.test_skyscanner.TestHotels) ... ok
test_construct_params (tests.test_skyscanner.TestTransport) ... ok
test_create_session (tests.test_skyscanner.TestTransport) ... ok
test_default_resp_callback_json (tests.test_skyscanner.TestTransport) ... ok
test_default_resp_callback_xml (tests.test_skyscanner.TestTransport) ... ok
test_get_markets_json (tests.test_skyscanner.TestTransport) ... ok
test_get_markets_xml (tests.test_skyscanner.TestTransport) ... ok
test_location_autosuggest_json (tests.test_skyscanner.TestTransport) ... ok
test_location_autosuggest_xml (tests.test_skyscanner.TestTransport) ... ok
test_with_error_handling_graceful (tests.test_skyscanner.TestTransport) ... 2016-06-28 23:07:53,357 - skyscanner.py:262 - WARNING -
2016-06-28 23:07:53,357 - skyscanner.py:262 - WARNING -
2016-06-28 23:07:53,357 - skyscanner.py:270 - WARNING - Too many requests in the last minute.
2016-06-28 23:07:53,357 - skyscanner.py:270 - WARNING - Too many requests in the last minute.
2016-06-28 23:07:53,357 - skyscanner.py:270 - WARNING - Too many requests in the last minute.
2016-06-28 23:07:53,357 - skyscanner.py:231 - ERROR - No JSON object could be decoded
2016-06-28 23:07:53,358 - skyscanner.py:270 - WARNING - Too many requests in the last minute.
2016-06-28 23:07:53,358 - skyscanner.py:231 - ERROR - Start tag expected, '<' not found, line 1, column 1
ok
test_with_error_handling_ignore (tests.test_skyscanner.TestTransport) ... 2016-06-28 23:07:53,358 - skyscanner.py:279 - ERROR -
2016-06-28 23:07:53,358 - skyscanner.py:231 - ERROR - No JSON object could be decoded
2016-06-28 23:07:53,358 - skyscanner.py:279 - ERROR -
2016-06-28 23:07:53,358 - skyscanner.py:231 - ERROR - No JSON object could be decoded
2016-06-28 23:07:53,358 - skyscanner.py:279 - ERROR -
2016-06-28 23:07:53,358 - skyscanner.py:231 - ERROR - No JSON object could be decoded
2016-06-28 23:07:53,358 - skyscanner.py:279 - ERROR -
2016-06-28 23:07:53,359 - skyscanner.py:231 - ERROR - None
2016-06-28 23:07:53,359 - skyscanner.py:279 - ERROR -
2016-06-28 23:07:53,359 - skyscanner.py:231 - ERROR - None
2016-06-28 23:07:53,359 - skyscanner.py:279 - ERROR -
2016-06-28 23:07:53,359 - skyscanner.py:231 - ERROR - None
2016-06-28 23:07:53,359 - skyscanner.py:279 - ERROR -
2016-06-28 23:07:53,359 - skyscanner.py:279 - ERROR -
ok
test_with_error_handling_strict (tests.test_skyscanner.TestTransport) ... 2016-06-28 23:07:53,359 - skyscanner.py:231 - ERROR - No JSON object could be decoded
2016-06-28 23:07:53,359 - skyscanner.py:231 - ERROR - No JSON object could be decoded
2016-06-28 23:07:53,359 - skyscanner.py:231 - ERROR - None
2016-06-28 23:07:53,360 - skyscanner.py:231 - ERROR - None
2016-06-28 23:07:53,360 - skyscanner.py:231 - ERROR - expected '>', line 1, column 57
2016-06-28 23:07:53,360 - skyscanner.py:231 - ERROR - expected '>', line 1, column 57
400
ok

======================================================================
FAIL: test_get_result_json (tests.test_skyscanner.TestFlights)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/niko/sandbox/python/skyscanner-python-sdk/tests/test_skyscanner.py", line 729, in test_get_result_json
    self.assertTrue(None != self.result)
  File "/Users/niko/sandbox/python/skyscanner-python-sdk/tests/test_skyscanner.py", line 58, in assertTrue
    expr, msg=msg or self._default_message())
AssertionError: False is not true

----------------------------------------------------------------------
Ran 31 tests in 97.374s

FAILED (failures=1)

Hi,

Digging my way through the code, here are some changes/refactorings which I suggest:

• more generic 'make_request' method. Nicely isolates 'requests' lib (it's used only there now). All other methods use it to talk to API.
• generic 'get_results' and 'create_session' methods, so the overall API of all classes becoming more in sync
• improvement for handling errors in response

Cheers, Denis

Hi!

I suggest some minor refactorings to be applied, the more important of which is having single API_HOST field to set up which SkyScanner environment to contact. My guess is that having this setting it would be possible to direct unit tests to some other environment than production.

Also added an improvement in unit tests by outputting actual API response on assert failure. It helps a lot to see if your failure was due to real error or to throttling limitations which is currently there.

Cheers, Denis

Bumps wheel from 0.23.0 to 0.38.1.

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Example params being passed to:

from skyscanner.skyscanner import Flights flights_service = Flights(settings.SKY_TOKEN) flights_service.skyscanner.get_result( {'inbounddate': '', 'currency': 'INR', 'includeCarriers': u'9W', 'originplace': u'CCU-sky', 'adults': 1, 'destinationplace': u'DEL-sky', 'locale': 'en-IN', 'country': 'IN', 'outbounddate': '2018-01-13', 'market': 'IN'})

However, the results don't come filtered with includeCarriers.
In the results we get other Carriers and also the results['Query'] as such.

"Query": { "DestinationPlace": "10957", "CabinClass": "Economy", "Adults": 1, "Locale": "en-IN", "Country": "IN", "OutboundDate": "2018-01-13", "Currency": "INR", "OriginPlace": "10401", "LocationSchema": "Default", "Infants": 0, "GroupPricing": false, "Children": 0 },

We tested with the same parameters in the API Test Harness and we got proper results.

Hi Guys,

I'm having a few issues using the Country Codes (e.g. IE or UK) from the Places API in fetching a Grid of Prices. I get the following issue:

HTTPError: 400 Client Error: Bad Request for url: http://partners.api.skyscanner.net/apiservices/browsegrid/v1.0/UK/GBP/en-GB/MAN/IE/2017-05/2017-05?apiKey=[API]: For this query please use the following service [BrowseRoutes]

Is there a way to:

(a) Get a response in the same way you do when you input cities? I don't see why the output should be any different if the city code is UK or LOND

(b) Can we filter the places api to filter out country codes?

I have reused the example from the documentation but every time I make a request I receive a response without submitted_query, images and car_classes lists. I'm using python 3.4.6

`from skyscanner.skyscanner import CarHire

carhire_service = CarHire('my_api_key')

result = carhire_service.get_result( market='UK', currency='GBP', locale='en-GB', pickupplace='27544008', dropoffplace='27544008', pickupdatetime='2017-04-18T10:00', dropoffdatetime='2017-04-25T10:00', driverage='21', userip='127.0.0.1').parsed

print(result) `

How do we access your list of airports and their codes, including things like "All London airports", so that we can develop our front end to speak to your api?

Hello! I'm trying to do something with SkyScanner API, and I decided to start with simple examples on Github. But it seems not to work, and the following error appears:

Can you help me to solve this problem? Or maybe I just do something wrong? Anyway, thank you!