A useful addition, especially when converting a large number of strings, would be to store/cache the results to some common strings somewhere (memory, mongodb database, redis, ...). I'm not sure what's the best way to do this to be generic enough. I had used a mongodb in my old geocoder and it worked well https://gist.github.com/themiurgo/3136205

However I'd like it to be more generic for this module. I'll think about it.

• added a test file for geonames
• retrieved more attributes from results
• added methods children and hierarchy
• reviewed slightly doc

question : how should be handled multiple results (e.g. the ones from hierarchy) ?

Does your code supports Google's reverse geocoding since they require the use of an API key? I quickly browsed through your documentation but couldn't find anything on how to use Google API key. Please advise.

When trying to encode an address whose result would contain a non-ASCII character (e.g. é, á, ž etc.), I get this error. Using iPython 2.7 in Anaconda on Windows 7. Any ideas? Thanks for the great library BTW!

In [58]: s = geocoder.bing("Champs de Mars, Paris", proxies=proxies)

In [59]: s
Out[59]: <[OK] Bing - Geocode [Champ de Mars, Paris, France]>

In [60]: s = geocoder.bing("Avenue Champs Elysees, Paris", proxies=proxies)
---------------------------------------------------------------------------
UnicodeEncodeError                        Traceback (most recent call last)
<ipython-input-60-62b4e3a20efb> in <module>()
----> 1 s = geocoder.bing("Avenue Champs Elysees, Paris", proxies=proxies)

C:\Documents\SW\Anaconda\lib\site-packages\geocoder\api.pyc in bing(location, **kwargs)
    205         > reverse
    206     """
--> 207     return get(location, provider='bing', **kwargs)
    208
    209

C:\Documents\SW\Anaconda\lib\site-packages\geocoder\api.pyc in get(location, **kwargs)
    101                   '>>> g = geocoder.get([45.68, -75.15], method="reverse
")')
    102             sys.exit()
--> 103     return options[provider][method](location, **kwargs)
    104
    105

C:\Documents\SW\Anaconda\lib\site-packages\geocoder\bing.pyc in __init__(self, location, **kwargs)
     65             'maxResults': 1,
     66         }
---> 67         self._initialize(**kwargs)
     68         self._bing_catch_errors()
     69

C:\Documents\SW\Anaconda\lib\site-packages\geocoder\base.pyc in _initialize(self, **kwargs)
     99         self._build_tree(self.content)
    100         self._exceptions()
--> 101         self._json()
    102
    103     def _json(self):

C:\Documents\SW\Anaconda\lib\site-packages\geocoder\base.pyc in _json(self)
    105             if bool(not key.startswith('_') and key not in self._exclude
):
    106                 self.fieldnames.append(key)
--> 107                 value = getattr(self, key)
    108                 if value:
    109                     self.json[key] = value

C:\Documents\SW\Anaconda\lib\site-packages\geocoder\bing.pyc in housenumber(self)
    105             expression = r'\d+'
    106             pattern = re.compile(expression)
--> 107             match = pattern.search(str(self.street))
    108             if match:
    109                 return match.group(0)

UnicodeEncodeError: 'ascii' codec can't encode character u'\xc9' in position 18:
 ordinal not in range(128)

This patch enables Travis CI to automatically scan for pep8 violations and report back in the build. Uses flake8 to perform this task.

One exception to the pep8 default rules is we allow 120 max line length instead of the default 79 characters.

Python 2 encoding issues are a living hell. Tried to do the best out of it, and it works well! 🙃 Thanks @ebreton for detecting these issues again!

& bumped the version number

Hi I am trying to get the city, state and country through the ip address.

My data frame has 500,000 rows and I need to apply it on each of them.

I am getting the the connection error after 200 records or so.

I even tried using time.sleep(5) and it still stops after 500 records or so.

Can you please provide alternates or solution to this.

Thank you.

David Masclet currently prepares gisgraphy geocoder V5. This PR provides a client implementation. API key policy still / test case handling needs to be clarified.

Hi,

The Opencage lookup seems to be broken again. I get the following error:

 File "..\lib\site-packages\geocoder\base.py", line 120, in _parse_json_with_fieldnames
    value = getattr(self, key)
  File "..\lib\site-packages\geocoder\opencage.py", line 359, in bbox
    south = self.raw['bounds']['southwest'].get('lat')

I can solve it by putting a try, except around the bit:

            try:
                value = getattr(self, key)
                if value:
                    self.json[key] = value
            except Exception as e:
                print(e)

but I'm not sure that that is the best solution... :)

I'm not sure how the new multiple search results have changed things and if it will be a general error, or only an error with opencage.

We noticed that after upgrading geocoder from 1.25.0 to later versions, the Google environment variables when using a client account do not get picked up, here is the error:

<ipython-input-3-4e48b1d75176> in <module>()
----> 1 geocoder.google(address)

.../geocoder/api.py in google(location, **kwargs)
    193         > elevation
    194     """
--> 195     return get(location, provider='google', **kwargs)
    196 
    197 

.../geocoder/api.py in get(location, **kwargs)
    159         if method not in options[provider]:
    160             raise ValueError("Invalid method")
--> 161     return options[provider][method](location, **kwargs)
    162 
    163 

.../geocoder/base.py in __init__(self, location, **kwargs)
    706 
    707         # check validity of provider key
--> 708         provider_key = self._get_api_key(kwargs.pop('key', None))
    709 
    710         # point to geocode, as a string or coordinates

.../geocoder/base.py in _get_api_key(cls, key)
    685         # raise exception if not valid key found
    686         if not key:
--> 687             raise ValueError('Provide API Key')
    688 
    689         return key

ValueError: Provide API Key

Hi Denis,

I have created this to address issue: #276 and add additional functionality.

Added all of the aliases as defined in: https://github.com/OpenCageData/address-formatting/blob/master/conf/components.yaml

Fixed the circular city lookup error and created a more robust lookup for the aliases if one does not exist.

Updated tests to include country and country_code

Hi,

I am working on a project to identify the location type using reverse geocoding and I am using the below code to do that:

g = geocoder.osm([x.lat,x.lng], method='reverse').json

And i am getting the result, which is mentioned below, I am trying to find more information regarding the "quality" and "type" tags, also, i want to know what does "yes" means in this context. Any help is much appreciated.

{
  "encoding": "utf-8",
  "status_code": 200,
  "place_id": "169621055",
  "county": "Suffolk County",
  "street": "Wall Street",
  "osm_id": "470231498",
  "lng": -73.42776365,
  "quality": "yes",
  "confidence": 10,
  "type": "yes",
  "state": "New York",
  "location": "11 Wall Street, New York",
  "provider": "osm",
  "housenumber": "11",
  "accuracy": 0.511,
  "status": "OK",
  "importance": 0.511,
  "bbox": {
    "northeast": [
      40.8716548,
      -73.4275981
    ],
    "southwest": [
      40.8715761,
      -73.4279292
    ]
  },
  "address": "11, Wall Street, Halesite, Suffolk County, New York, 11743, United States of America",
  "lat": 40.87161545,
  "postal": "11743",
  "ok": true,
  "country": "United States of America",
  "region": "New York",
  "osm_type": "way",
  "place_rank": "30"
}

hey I was just doing stuff with geocoder and I reeally loved it. However I guess there is some issue in it here is the details:

As you can see ip.ok is giving True but ip.json.["ok"] is returning False which doesnot satisfy this statement "If geocoder was able to contact the server, but no result could be found for the given search terms, the ok attribute on the returned object will be False." from the docs.

Now Yandex API demands the key for use & it is not tolerant to the parameter "kind" without the value. I made a fork & did a couple of commits. You can use my correction or do it yourself. I have tested mine & it does work.

The OpenCageResult.bbox property is defined as:

@property
def bbox(self):
    south = self._bounds.get('southwest', {}).get('lat')
    north = self._bounds.get('northeast', {}).get('lat')
    west = self._bounds.get('southwest', {}).get('lng')
    east = self._bounds.get('northeast', {}).get('lng')
    if all([south, west, north, east]):
        return BBox.factory([south, west, north, east]).as_dict

But the BBox initializer expects a list argument, in BBox.__init__ to be:

    elif bbox is not None and all(bbox):
        self.west, self.south, self.east, self.north = map(float, bbox)

It looks like OpenCageResult.bbox should be changed to:

return BBox.factory([west, south, east, north]).as_dict

Hello, I am using Geocoder for an AI application, what happens is that when it ends it gives me this error:

Exception ignored on calling ctypes callback function: <function catch_errors..call_with_this at 0x000001984ECBDF70>

Traceback (most recent call last):

File "C:\Users\diego\AppData\Local\Programs\Python\Python39\lib\site-packages\comtypes_comobject.py", line 91, in call_with_this

File "C:\Users\diego\AppData\Local\Programs\Python\Python39\lib\logging_init_.py", line 1474, in error

File "C:\Users\diego\AppData\Local\Programs\Python\Python39\lib\logging_init_.py", line 1699, in isEnabledFor

TypeError: 'NoneType' object is not callable

This error only occurs when I import the Geocoder library.